[ https://issues.apache.org/jira/browse/HDFS-10351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15264964#comment-15264964 ]
Anu Engineer commented on HDFS-10351: ------------------------------------- +1, pending jenkins. Two minor comments: # Technically this can happen even if there is an overflow. But I would rather have this check and fail the write than otherwise {{(off + len) < 0)}} # Where are we using this call from ? > Ozone: Optimize key writes to chunks by providing a bulk write implementation > in ChunkOutputStream. > --------------------------------------------------------------------------------------------------- > > Key: HDFS-10351 > URL: https://issues.apache.org/jira/browse/HDFS-10351 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: ozone > Reporter: Chris Nauroth > Assignee: Chris Nauroth > Attachments: HDFS-10351-HDFS-7240.001.patch > > > HDFS-10268 introduced the {{ChunkOutputStream}} class as part of end-to-end > integration of Ozone receiving key content and writing it to chunks in a > container. That patch provided an implementation of the mandatory > single-byte write method. We can improve performance by adding an > implementation of the bulk write method too. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org