[ https://issues.apache.org/jira/browse/HDFS-8449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15270622#comment-15270622 ]
Kai Zheng commented on HDFS-8449: --------------------------------- Thanks [~libo-intel] for the updates, making the added test more reliable. * Glad to see you use {{DFSTestUtil.waitForDatanodeState}} to ensure the state before moving to next step. Could you enhance {{TestReconstructStripedFile}} similarly? * I'm not sure about the following block codes are necessary. {code} final BlockManager bm = cluster.getNamesystem().getBlockManager(); BlockManagerTestUtil.getComputedDatanodeWork(bm); cluster.triggerHeartbeats(); {code} * Could we use {{DFSTestUtil.writeFile}} to generate the test file? * Could we share {{TestReconstructStripedFile#waitForRecoveryFinished}} and avoid {{waitForRecoveryFinished}}? +1 once these are addressed. Thanks! > Add tasks count metrics to datanode for ECWorker > ------------------------------------------------ > > Key: HDFS-8449 > URL: https://issues.apache.org/jira/browse/HDFS-8449 > Project: Hadoop HDFS > Issue Type: Sub-task > Reporter: Li Bo > Assignee: Li Bo > Attachments: HDFS-8449-000.patch, HDFS-8449-001.patch, > HDFS-8449-002.patch, HDFS-8449-003.patch, HDFS-8449-004.patch, > HDFS-8449-005.patch, HDFS-8449-006.patch, HDFS-8449-007.patch, > HDFS-8449-008.patch, HDFS-8449-009.patch > > > This sub task try to record ec recovery tasks that a datanode has done, > including total tasks, failed tasks and sucessful tasks. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org