[
https://issues.apache.org/jira/browse/HDFS-2173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15283491#comment-15283491
]
Andras Bokor commented on HDFS-2173:
------------------------------------
[~andrew.wang]
Thanks a lot for reviewing this.
Yesterday I was not able to comment on JIRA due to lock down.
bq. writeAll is not quite right though...
That was my concern too. It was not obvious based on the description and the
tests. I should have commented my concern. My fault.
I updated my patch and uploaded [^HDFS-2173.02.patch] and
[^HDFS-2173.03.patch]. They do the same but with a different solution.
Which do you think is more straightforward?
In spite of that I uploaded a patch it seems [~hadoopqa] was not triggered.
> saveNamespace should not throw IOE when only one storage directory fails to
> write VERSION file
> ----------------------------------------------------------------------------------------------
>
> Key: HDFS-2173
> URL: https://issues.apache.org/jira/browse/HDFS-2173
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: Edit log branch (HDFS-1073), 0.23.0
> Reporter: Todd Lipcon
> Assignee: Andras Bokor
> Attachments: HDFS-2173.01.patch, HDFS-2173.02.patch,
> HDFS-2173.03.patch
>
>
> This JIRA tracks a TODO in TestSaveNamespace. Currently, if, while writing
> the VERSION files in the storage directories, one of the directories fails,
> the entire operation throws IOE. This is unnecessary -- instead, just that
> directory should be marked as failed.
> This is targeted to be fixed _after_ HDFS-1073 is merged to trunk, since it
> does not ever dataloss, and would rarely occur in practice (the dir would
> have to fail between writing the fsimage file and writing VERSION)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
