[ 
https://issues.apache.org/jira/browse/HDFS-10390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15292269#comment-15292269
 ] 

Lei (Eddy) Xu commented on HDFS-10390:
--------------------------------------

Hi, [~xiaobingo]. Nice work.

In {{TestAsyncDFSRename#tesetAsyncAPIWithException}}, could you add {{fail()}} 
to each {{try...catch}} to make sure an Exception was indeed thrown.  i.e.,

{code}
try {
  retFuture = ...
  retFuture.get();
  fail("....");
} catch (ExcutionException ..) {
  ...
}
{code}

* Maybe we can move many of the tests in {{TestAsyncDFSRename}} to 
{{TestAsyncDFS}}, as many of them are not {{rename}}-related. But it is not 
necessary to be done in this JIRA.

+1 pending. 

> Implement asynchronous setAcl/getAclStatus for DistributedFileSystem
> --------------------------------------------------------------------
>
>                 Key: HDFS-10390
>                 URL: https://issues.apache.org/jira/browse/HDFS-10390
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: fs
>            Reporter: Xiaobing Zhou
>            Assignee: Xiaobing Zhou
>         Attachments: HDFS-10390-HDFS-9924.000.patch, 
> HDFS-10390-HDFS-9924.001.patch, HDFS-10390-HDFS-9924.002.patch, 
> HDFS-10390-HDFS-9924.003.patch, HDFS-10390-HDFS-9924.004.patch, 
> HDFS-10390-HDFS-9924.005.patch, HDFS-10390-HDFS-9924.006.patch
>
>
> This is proposed to implement asynchronous setAcl/getAclStatus.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to