[ https://issues.apache.org/jira/browse/HDFS-10459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15300298#comment-15300298 ]
Hadoop QA commented on HDFS-10459: ---------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s {color} | {color:blue} Docker mode activated. {color} | | {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 5s {color} | {color:red} HDFS-10459 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. {color} | \\ \\ || Subsystem || Report/Notes || | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12806144/HDFS-10459.001.patch | | JIRA Issue | HDFS-10459 | | Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/15562/console | | Powered by | Apache Yetus 0.2.0 http://yetus.apache.org | This message was automatically generated. > getTurnOffTip computes needed block incorrectly for threshold = 1 > ----------------------------------------------------------------- > > Key: HDFS-10459 > URL: https://issues.apache.org/jira/browse/HDFS-10459 > Project: Hadoop HDFS > Issue Type: Bug > Affects Versions: 0.22.0, 0.23.0 > Reporter: Eric Badger > Assignee: Eric Badger > Attachments: HDFS-10459.001.patch > > > The fix added in HDFS-2002 only works in cases where threshold < 1, but not > when threshold = 1. There is a '+1' added to the computation because of this > assumption. I propose that instead of adding a '+1', we just set > blockThreshold to be the ceiling of blocksTotal*threshold. Since we need to > be >= blockThreshold to get out of safe mode, this will work. >14.9 is the > same as =15, since blocks work in integer values. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org