[
https://issues.apache.org/jira/browse/HDFS-10463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15301465#comment-15301465
]
Aaron T. Myers commented on HDFS-10463:
---------------------------------------
[~templedf] - trunk patch looks pretty good to me, but seems like the branch-2
patch had this very test fail. I'll be +1 once that's addressed.
> TestRollingFileSystemSinkWithHdfs needs some cleanup
> ----------------------------------------------------
>
> Key: HDFS-10463
> URL: https://issues.apache.org/jira/browse/HDFS-10463
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 2.9.0
> Reporter: Daniel Templeton
> Assignee: Daniel Templeton
> Priority: Critical
> Attachments: HDFS-10463.001.patch, HDFS-10463.branch-2.001.patch
>
>
> There are three primary issues. The most significant is that the
> {{testFlushThread()}} method doesn't clean up after itself, which can cause
> other tests to fail. The other big issue is that the {{testSilentAppend()}}
> method is testing the wrong thing. An additional minor issue is that none of
> the tests are careful about making sure the metrics system gets shutdown in
> all cases.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
