[ https://issues.apache.org/jira/browse/HDFS-10375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15316910#comment-15316910 ]
John Zhuge commented on HDFS-10375: ----------------------------------- +1(non-binding) after reverting the change in {{ValueQueue.java}}. File a new jira to fix that typo. > Remove redundent TestMiniDFSCluster.testDualClusters > ---------------------------------------------------- > > Key: HDFS-10375 > URL: https://issues.apache.org/jira/browse/HDFS-10375 > Project: Hadoop HDFS > Issue Type: Test > Components: test > Affects Versions: 2.6.0 > Reporter: John Zhuge > Assignee: Jiayi Zhou > Priority: Trivial > Labels: newbie > Fix For: 2.8.0 > > Attachments: HDFS-10375.001.patch > > > Unit test {{TestMiniDFSCluster.testDualClusters}} is redundant because > {{testClusterWithoutSystemProperties}} already proves > {{cluster.getDataDirectory() == getProp(HDFS_MINIDFS_BASEDIR) + "/data"}}. > This unit test sets HDFS_MINIDFS_BASEDIR to 2 different values and brings up > 2 clusters, of course they will have different data directory. > Remove it to save the time to bring up 2 mini clusters. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org