[
https://issues.apache.org/jira/browse/HDFS-10375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15317358#comment-15317358
]
John Zhuge edited comment on HDFS-10375 at 6/6/16 10:09 PM:
------------------------------------------------------------
[~clouderajiayi] The patch 003 is wrong because it is incremental to 002. It
should be a diff from the trunk. It seems your local branch is ahead of trunk
by 2 commits : the older one for patch 002 and the newer one for patch 003.
Please merge them into 1 commit by running {{git rebase -i HEAD~2}} (fixup the
newer commit) then run format-patch again.
was (Author: jzhuge):
[~clouderajiayi] The patch 003 is wrong because it is incremental to 002. It
should be a diff from the trunk. It seems your local branch is ahead of trunk
by 2 commits : the older one for patch 002 and the newer one for patch 003. In
this case, please run {{git format-patch --stdout HEAD~2 >
HDFS-10375.NNN.patch}}.
> Remove redundant TestMiniDFSCluster.testDualClusters
> ----------------------------------------------------
>
> Key: HDFS-10375
> URL: https://issues.apache.org/jira/browse/HDFS-10375
> Project: Hadoop HDFS
> Issue Type: Test
> Components: test
> Affects Versions: 2.6.0
> Reporter: John Zhuge
> Assignee: Jiayi Zhou
> Priority: Trivial
> Labels: newbie
> Attachments: HDFS-10375.002.patch, HDFS-10375.003.patch
>
>
> Unit test {{TestMiniDFSCluster.testDualClusters}} is redundant because
> {{testClusterWithoutSystemProperties}} already proves
> {{cluster.getDataDirectory() == getProp(HDFS_MINIDFS_BASEDIR) + "/data"}}.
> This unit test sets HDFS_MINIDFS_BASEDIR to 2 different values and brings up
> 2 clusters, of course they will have different data directory.
> Remove it to save the time to bring up 2 mini clusters.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
