[ https://issues.apache.org/jira/browse/HDFS-10505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15330492#comment-15330492 ]
Colin Patrick McCabe commented on HDFS-10505: --------------------------------------------- Thanks for this, [~surendrasingh]. It's good to see progress on supporting ACLs here! I am confused by the changes for setting {{latestStringId}} to 1, or special-casing {{null}} in {{registerStringId}}. If we are going to do "magical" things with special indexes in the string table, we need to document it somewhere. Actually, though, I would prefer to simply handle it without the magic. We know that a null entry for an ACL name simply means that the name was an empty string. You can see that in {{AclEntry.java}}: {code} String name = split[index]; if (!name.isEmpty()) { builder.setName(name); } {code} In ReverseXML, we should simply translate these {{null}} ACL names back into empty strings, and then the existing logic for handling the string table would work, with no magic. We also need a test case which has null ACL names, so that this code is being exercised. > OIV's ReverseXML processor should support ACLs > ---------------------------------------------- > > Key: HDFS-10505 > URL: https://issues.apache.org/jira/browse/HDFS-10505 > Project: Hadoop HDFS > Issue Type: Bug > Components: tools > Affects Versions: 2.8.0 > Reporter: Colin Patrick McCabe > Assignee: Surendra Singh Lilhore > Attachments: HDFS-10505-001.patch > > > OIV's ReverseXML processor should support ACLs. Currently ACLs show up in > the fsimage.xml file, but we don't reconstruct them with ReverseXML. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org