[
https://issues.apache.org/jira/browse/HDFS-10511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15330598#comment-15330598
]
Bob Hansen commented on HDFS-10511:
-----------------------------------
Thanks, [~anatoli.shein].
A few more little places we should touch for consistency:
Let's have hdfsGetLastError return -1 or 0 also.
The hdfs*Builder* and hdfs*Conf* functions should set errno to 0 on entry.
hdfsBuilderConfGetInt should set errno to 0 on success and set errno and return
-1 on failure.
hdfs*Logging* should set errno to 0 on success and set errno and return -1 on
failure.
> libhdfs++: make error returning mechanism consistent across all hdfs
> operations
> -------------------------------------------------------------------------------
>
> Key: HDFS-10511
> URL: https://issues.apache.org/jira/browse/HDFS-10511
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
> Reporter: Anatoli Shein
> Assignee: Anatoli Shein
> Attachments: HDFS-10511.HDFS-8707.000.patch,
> HDFS-10511.HDFS-8707.000.patch
>
>
> Errno should always be set.
> If function is returning a code on stack, it should be consistent with errno.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
