[
https://issues.apache.org/jira/browse/HDFS-10524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15330670#comment-15330670
]
James Clampffer commented on HDFS-10524:
----------------------------------------
Just a couple minor things, everything looks solid functionally.
Do we need to use std::tuple in FileSystemImpl::SetPermission and SetOwner to
make 1-tuples? They'll likely get inlined away but less templates generally
makes things easier to debug.
{code}
auto callstate = std::make_shared<std::promise<std::tuple<Status>>>();
...
callstate->set_value(std::make_tuple(s));
...
auto returnstate = future.get();
Status stat = std::get<0>(returnstate);
{code}
It looks like there is some duplicate error checking code.
FileSystemImpl::SetPermissions will check the path and permission mask and then
call NameNodeOperations::SetPermission which does the same. Do we plan on
making the NameNodeOperations object accessable outside of FileSystem(Impl)?
If not it might be worth getting rid of the checks in one of them, or better
yet factoring out the checking code into a function and using that in both
places.
> libhdfs++: Implement chmod and chown
> ------------------------------------
>
> Key: HDFS-10524
> URL: https://issues.apache.org/jira/browse/HDFS-10524
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
> Reporter: Anatoli Shein
> Assignee: Anatoli Shein
> Attachments: HDFS-10524.HDFS-8707.000.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
