[ https://issues.apache.org/jira/browse/HDFS-10544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhe Zhang updated HDFS-10544: ----------------------------- Attachment: HDFS-10544.02.patch Uploading v2 patch. So we have 2 alternatives: * v1 patch: add {{useLogicalUri}} to take String as parameter * v2 patch: throw {{IllegalArgumentException}} before trying to determine whether to use logical URI. I'm hesitating between the 2 options because the documentation is not completely clear about {{dfs.nameservices}}. Could it be an arbitrary string? If that arbitrary string fails to form a legal URI (when prefixed with {{hdfs://}}), shall we treat it just as a Runtime exception, or we should look for that arbitrary string prefixed with {{dfs.namenode.servicerpc-address}} in the config? Any suggestions are very welcome. > Balancer doesn't work with IPFailoverProxyProvider > -------------------------------------------------- > > Key: HDFS-10544 > URL: https://issues.apache.org/jira/browse/HDFS-10544 > Project: Hadoop HDFS > Issue Type: Bug > Reporter: Zhe Zhang > Assignee: Zhe Zhang > Attachments: HDFS-10544.00.patch, HDFS-10544.01.patch, > HDFS-10544.02.patch > > > Right now {{Balancer}} gets the NN URIs through > {{DFSUtil#getNameServiceUris}}, which returns logical URIs in HA is enabled. > If {{IPFailoverProxyProvider}} is used, {{Balancer}} will not be able to > start. > I think the bug is at {{DFSUtil#getNameServiceUris}}: > {code} > for (String nsId : getNameServiceIds(conf)) { > if (HAUtil.isHAEnabled(conf, nsId)) { > // Add the logical URI of the nameservice. > try { > ret.add(new URI(HdfsConstants.HDFS_URI_SCHEME + "://" + nsId)); > {code} > Then {{if}} clause should also consider if the {{FailoverProxyProvider}} has > {{useLogicalURI}} enabled. If not, {{getNameServiceUris}} should try to > resolve the physical URI for this nsId. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org