[ 
https://issues.apache.org/jira/browse/HDFS-10541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anu Engineer updated HDFS-10541:
--------------------------------
    Attachment: HDFS-10541-HDFS-1312.001.patch

[~eddyxu] Thanks for filing this issue. It is a confusing message. However the 
message is _technically_ correct, that is timestamp is 0 in the plan file, 
which is it is not a valid time stamp. I think the issue is not in the execute 
phase, but rather in the plan phase. We should not be generating these empty 
plan files with invalid timestamps in the first place. The attached patch skips 
generating a plan if we don't have valid steps.

Please let me know if this addresses your concern.

> When no actions in plan, error message says "Plan was generated more than 24 
> hours ago"
> ---------------------------------------------------------------------------------------
>
>                 Key: HDFS-10541
>                 URL: https://issues.apache.org/jira/browse/HDFS-10541
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode
>    Affects Versions: HDFS-1312
>            Reporter: Lei (Eddy) Xu
>            Assignee: Anu Engineer
>            Priority: Minor
>         Attachments: HDFS-10541-HDFS-1312.001.patch
>
>
> The message is misleading. Instead, it should make it clear that there are no 
> steps (or no action) to take in this plan - and should probably not error out.
> {code}
> 16/06/16 14:56:53 INFO command.Command: Executing "execute plan" command
> Plan was generated more than 24 hours ago.
>       at 
> org.apache.hadoop.hdfs.server.datanode.DiskBalancer.verifyTimeStamp(DiskBalancer.java:387)
>       at 
> org.apache.hadoop.hdfs.server.datanode.DiskBalancer.verifyPlan(DiskBalancer.java:315)
>       at 
> org.apache.hadoop.hdfs.server.datanode.DiskBalancer.submitPlan(DiskBalancer.java:173)
>       at 
> org.apache.hadoop.hdfs.server.datanode.DataNode.submitDiskBalancerPlan(DataNode.java:3059)
>       at 
> org.apache.hadoop.hdfs.protocolPB.ClientDatanodeProtocolServerSideTranslatorPB.submitDiskBalancerPlan(ClientDatanodeProtocolServerSideTranslatorPB.java:299)
>       at 
> org.apache.hadoop.hdfs.protocol.proto.ClientDatanodeProtocolProtos$ClientDatanodeProtocolService$2.callBlockingMethod(ClientDatanodeProtocolProtos.java:17509)
>       at 
> org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:617)
>       at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:1073)
>       at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:2086)
>       at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:2082)
>       at java.security.AccessController.doPrivileged(Native Method)
>       at javax.security.auth.Subject.doAs(Subject.java:415)
>       at 
> org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1693)
>       at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2080)
> {code}
> This happens when a plan looks like the following one:
> {code}
> {"volumeSetPlans":[],"nodeName":"a.b.c","nodeUUID":null,"port":20001,"timeStamp":0}
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to