[ 
https://issues.apache.org/jira/browse/HDFS-10548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15340836#comment-15340836
 ] 

Colin Patrick McCabe commented on HDFS-10548:
---------------------------------------------

I would love to see this class go away.  It is truly a relic of another time, 
which lasted much longer than it should.  I think the only remaining use case 
for it is when using sockets that don't have associated channels (SOCKS sockets 
don't, I think?)  We should be able to create adaptors for those, though, 
assuming anyone even uses SOCKS with the DN any more.  Unfortunately I don't 
have a lot of time to review this at the moment, though.

> Remove the long deprecated BlockReaderRemote
> --------------------------------------------
>
>                 Key: HDFS-10548
>                 URL: https://issues.apache.org/jira/browse/HDFS-10548
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs
>            Reporter: Kai Zheng
>            Assignee: Kai Zheng
>
> To lessen the maintain burden like raised in HDFS-8901, suggest we remove 
> {{BlockReaderRemote}} class that's deprecated very long time ago. 
> From {{BlockReaderRemote}} header:
> {quote}
>  * @deprecated this is an old implementation that is being left around
>  * in case any issues spring up with the new {@link BlockReaderRemote2}
>  * implementation.
>  * It will be removed in the next release.
> {quote}
> From {{BlockReaderRemote2}} class header:
> {quote}
>  * This is a new implementation introduced in Hadoop 0.23 which
>  * is more efficient and simpler than the older BlockReader
>  * implementation. It should be renamed to BlockReaderRemote
>  * once we are confident in it.
> {quote}
> So even further, after getting rid of the old class, we could rename as the 
> comment suggested: BlockReaderRemote2 => BlockReaderRemote.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to