[
https://issues.apache.org/jira/browse/HDFS-1777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13013959#comment-13013959
]
Uma Maheswara Rao G commented on HDFS-1777:
-------------------------------------------
Thanks to Aaron & Jakob for spending time and giving comments.
I agree with you, When i checked the compiled code with a decompiler tool, i
observed that Java compiler itself appending the strings.
|is it really even necessary to have an umbrella JIRA?),
My intention is to identify all kind of log related issues and raise as
subtasks to this issue ( by grouping similar occurances as one subtask).
For example:
catch (IOException e) {
LOG.error("getEditLogSize: editstream.length failed. removing editlog
(" +
idx + ") " + es.getName());
Here , it will be helpful if we include the exception also in error log
messages to identify the problems quickly.
> HDFS Log improvement Umbrella
> -----------------------------
>
> Key: HDFS-1777
> URL: https://issues.apache.org/jira/browse/HDFS-1777
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node, name-node
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
>
> In log messages we used so many '+' operators to construct the message. So
> many string object creations will happen. Instead we can use StringBuilder
> and append all the strings to it.So, we can avoid unncessary String object
> creations.
> So created one Umbrella issue and we can link the all log improvement issues
> to it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
