[ 
https://issues.apache.org/jira/browse/HDFS-10440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352354#comment-15352354
 ] 

Vinayakumar B commented on HDFS-10440:
--------------------------------------

1. I didn't mean to change existing {{DataNode#getNamenodeAddresses()}} output. 
It breaks the compatibility. So let it be just hostname. After this, 
{{BPSA#getNameNodeAddress()}} could be private.
{code}         for (BPServiceActor actor : bpos.getBPServiceActors()) {
-          info.put(actor.getNNSocketAddress().getHostName(),
+          info.put(actor.getNameNodeAddress(),
               bpos.getBlockPoolId());{code}

2. I am not very sure about giving link to {{/conf}} is good idea here since 
other pages dont have this yet. May be this could be taken as a separate 
improvement, together for all HTML pages. 
{code}<li><a href="conf">Configuration</a></li>{code}

Other changes are looks good. Thanks for updates.
+1, once these are addressed.

FYI, You dont need to change the Jira status to "In-Progress" and back to 
"Patch Available" every time.
Jenkins will pick up directly once the latest patch file is updated.



> Improve DataNode web UI
> -----------------------
>
>                 Key: HDFS-10440
>                 URL: https://issues.apache.org/jira/browse/HDFS-10440
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: datanode, ui
>    Affects Versions: 2.7.0
>            Reporter: Weiwei Yang
>            Assignee: Weiwei Yang
>         Attachments: HDFS-10440.001.patch, HDFS-10440.002.patch, 
> HDFS-10440.003.patch, HDFS-10440.004.patch, HDFS-10440.005.patch, 
> HDFS-10440.006.patch, HDFS-10440.007.patch, datanode_2nns.html.002.jpg, 
> datanode_html.001.jpg, datanode_loading_err.002.jpg, 
> datanode_utilities.001.jpg, datanode_utilities.002.jpg, dn_web_ui.003.jpg, 
> dn_web_ui_mockup.jpg, nn_dfs_storage_types.jpg
>
>
> At present, datanode web UI doesn't have much information except for node 
> name and port. Propose to add more information similar to namenode UI, 
> including, 
> * Static info (version, block pool  and cluster ID)
> * Block pools info (BP IDs, namenode address, actor states)
> * Storage info (Volumes, capacity used, reserved, left)
> * Utilities (logs)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to