[ https://issues.apache.org/jira/browse/HDFS-10594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15362497#comment-15362497 ]
Yiqun Lin commented on HDFS-10594: ---------------------------------- Attach a initial patch. > CacheReplicationMonitor should recursively rescan the path when the inode of > the path is directory > -------------------------------------------------------------------------------------------------- > > Key: HDFS-10594 > URL: https://issues.apache.org/jira/browse/HDFS-10594 > Project: Hadoop HDFS > Issue Type: Bug > Components: caching > Affects Versions: 2.7.1 > Reporter: Yiqun Lin > Assignee: Yiqun Lin > > In {{CacheReplicationMonitor#rescanCacheDirectives}}, it should recursively > rescan the path when the inode of the path is a directory. In these code: > {code} > } else if (node.isDirectory()) { > INodeDirectory dir = node.asDirectory(); > ReadOnlyList<INode> children = dir > .getChildrenList(Snapshot.CURRENT_STATE_ID); > for (INode child : children) { > if (child.isFile()) { > rescanFile(directive, child.asFile()); > } > } > } > {code} > If we did the this logic, it means that some inode files will be ignored when > the child inode is also a directory and there are some other child inode file > in it. Finally the child's child file which belong to this path will not be > cached. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org