[ https://issues.apache.org/jira/browse/HDFS-10548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15363003#comment-15363003 ]
Colin Patrick McCabe commented on HDFS-10548: --------------------------------------------- Thanks for tackling this, guys. It is good to see this code duplication finally go away. Next target: {{BlockReaderLocalLegacy}}? I do think renaming {{BlockReaderRemote2}} will make merging code back to branch-2 more difficult-- you might want to reconsider that. > Remove the long deprecated BlockReaderRemote > -------------------------------------------- > > Key: HDFS-10548 > URL: https://issues.apache.org/jira/browse/HDFS-10548 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs > Reporter: Kai Zheng > Assignee: Kai Zheng > Fix For: 3.0.0-alpha1 > > Attachments: HDFS-10548-v1.patch, HDFS-10548-v2.patch, > HDFS-10548-v3.patch > > > To lessen the maintain burden like raised in HDFS-8901, suggest we remove > {{BlockReaderRemote}} class that's deprecated very long time ago. > From {{BlockReaderRemote}} header: > {quote} > * @deprecated this is an old implementation that is being left around > * in case any issues spring up with the new {@link BlockReaderRemote2} > * implementation. > * It will be removed in the next release. > {quote} > From {{BlockReaderRemote2}} class header: > {quote} > * This is a new implementation introduced in Hadoop 0.23 which > * is more efficient and simpler than the older BlockReader > * implementation. It should be renamed to BlockReaderRemote > * once we are confident in it. > {quote} > So even further, after getting rid of the old class, we could rename as the > comment suggested: BlockReaderRemote2 => BlockReaderRemote. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org