[
https://issues.apache.org/jira/browse/HDFS-10567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15363562#comment-15363562
]
Anu Engineer commented on HDFS-10567:
-------------------------------------
[~xiaobingo] Thank you very much for the improvements in the messages in help.
There is one improvement that somehow does not feel right.
{noformat}
withDescription("Describes how many errors in integer " + "can be tolerated
while copying between a pair of disks.")
{noformat}
We seem to have added "in integer" as a unit. Does not how many errors convey
the same meaning ?
All other changes look good.
> Improve plan command help message
> ---------------------------------
>
> Key: HDFS-10567
> URL: https://issues.apache.org/jira/browse/HDFS-10567
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode
> Reporter: Lei (Eddy) Xu
> Assignee: Xiaobing Zhou
> Attachments: HDFS-10567-HDFS-10576.001.patch,
> HDFS-10567-HDFS-1312.000.patch
>
>
> {code}
> --bandwidth <arg> Maximum disk bandwidth to be consumed by
> diskBalancer. e.g. 10
> --maxerror <arg> Describes how many errors can be
> tolerated while copying between a pair
> of disks.
> --out <arg> File to write output to, if not
> specified defaults will be used.
> --plan <arg> creates a plan for datanode.
> --thresholdPercentage <arg> Percentage skew that wetolerate before
> diskbalancer starts working e.g. 10
> --v Print out the summary of the plan on
> console
> {code}
> We should
> * Put the unit into {{--bandwidth}}, or its help message. Is it an integer or
> float / double number? Not clear in CLI message.
> * Give more details about {{--plan}}. It is not clear what the {{<arg>}} is
> for.
> * {{--thresholdPercentage}}, has typo {{wetolerate}} in the error message.
> Also it needs to indicated that it is the difference between space
> utilization between two disks / volumes. Is it an integer or float / double
> number?
> Thanks.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
