[ https://issues.apache.org/jira/browse/HDFS-10579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15366858#comment-15366858 ]
Anu Engineer edited comment on HDFS-10579 at 7/7/16 10:07 PM: -------------------------------------------------------------- [~haibochen] Thanks for the comments bq. xFrameOption and xFrameOptionIsEnabled (of HttpServer2) are declared as static but used as instance variables. Can you make them non-static? Of course, QuotingInputFilter has to be non-static to access them Just wanted to let you know that I will make this change and post that patch to the new Hadoop Common Jira that I will be creating based on your suggestion. I will tag you on that Jira so that you can look at the changes. I should be able to post a patch by EOD. btw, looks like YARN addressed this issue in this patch. https://issues.apache.org/jira/browse/YARN-5076 was (Author: anu): [~haibochen] Thanks for the comments bq. xFrameOption and xFrameOptionIsEnabled (of HttpServer2) are declared as static but used as instance variables. Can you make them non-static? Of course, QuotingInputFilter has to be non-static to access them Just wanted to let you know that I will make this change and post that patch to the new Hadoop Common Jira that I will be creating based on your suggestion. I will tag on that Jira so that you can look at the changes. I should be able to post a patch by EOD. btw, looks like YARN addressed this issue in this patch. https://issues.apache.org/jira/browse/YARN-5076 > HDFS web interfaces lack configs for X-FRAME-OPTIONS protection > --------------------------------------------------------------- > > Key: HDFS-10579 > URL: https://issues.apache.org/jira/browse/HDFS-10579 > Project: Hadoop HDFS > Issue Type: Bug > Components: datanode, namenode > Affects Versions: 3.0.0-alpha1 > Reporter: Anu Engineer > Assignee: Anu Engineer > Fix For: 2.9.0 > > Attachments: HDFS-10579.001.patch, HDFS-10579.002.patch > > > This JIRA proposes to extend the work done in HADOOP-12964 and enable a > configuration value that enables or disables that option. This JIRA will also > add an ability to pick the right x-frame-option, since right now it looks > like we have hardcoded that to SAMEORIGIN. > This allows HDFS to remain backward compatible as required by the branch-2. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org