[ 
https://issues.apache.org/jira/browse/HDFS-10619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15375559#comment-15375559
 ] 

Zhe Zhang commented on HDFS-10619:
----------------------------------

This looks a good fix. Thanks Daryn. 

If an iip is created but {{getPath}} is never called, we are increasing the 
memory usage by 1 {{String}}. But I think this is pretty rare so overall the 
fix is an improvement.

Thoughts from others? I'll hold off a +1 till the end of today (because of the 
above tradeoff).

> Cache path in InodesInPath
> --------------------------
>
>                 Key: HDFS-10619
>                 URL: https://issues.apache.org/jira/browse/HDFS-10619
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HDFS-10619.patch
>
>
> INodesInPath#getPath, a frequently called method, dynamically builds the 
> path.  IIP should cache the path upon construction.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to