[ https://issues.apache.org/jira/browse/HDFS-10614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15378688#comment-15378688 ]
Jing Zhao commented on HDFS-10614: ---------------------------------- Thanks for the fix and review, [~vinayrpet] and [~ajisakaa]. The patch also looks good to me. One question is, before we remove the block from the storageInfo, whether we can also add an extra check to make sure the reported block's GS is greater than the stored block. In this way the logic will be the same with {{setGenerationStampAndVerifyReplicas}} in {{updatePipeline}}. > Appended blocks can be closed even before IBRs from DataNodes > ------------------------------------------------------------- > > Key: HDFS-10614 > URL: https://issues.apache.org/jira/browse/HDFS-10614 > Project: Hadoop HDFS > Issue Type: Bug > Reporter: Vinayakumar B > Assignee: Vinayakumar B > Attachments: HDFS-10614.01.patch, HDFS-10614.02.patch > > > Scenario: > 1. Open the file for append() > 2. Trigger append pipeline setup by adding some data. > 3. Consider RECEIVING IBRs of DNs reaches NN first. > 4. updatePipeline() rpc sent to namenode to update the pipeline. > 5. Now, if complete() is called on the file even before closing the > pipeline, then block will be COMPLETE, even before block is actually > FINALIZED at DN side and file will be closed. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org