[ https://issues.apache.org/jira/browse/HDFS-10650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384879#comment-15384879 ]
Xiao Chen commented on HDFS-10650: ---------------------------------- Thanks [~jzhuge] for creating the jira and providing a fix. I think this makes sense, though I hope Chris could comment on whether this was just a bug or somewhat intentional / history-involved. Also, in {{primitiveMkdir}}, why remove the null check? {code} - if (absPermission == null) { - absPermission = applyUMask(null); - } - + absPermission = applyUMaskDir(absPermission); {code} > DFSClient#mkdirs and DFSClient#primitiveMkdir should use default directory > permission > ------------------------------------------------------------------------------------- > > Key: HDFS-10650 > URL: https://issues.apache.org/jira/browse/HDFS-10650 > Project: Hadoop HDFS > Issue Type: Bug > Affects Versions: 2.6.0 > Reporter: John Zhuge > Assignee: John Zhuge > Priority: Minor > Attachments: HDFS-10650.001.patch > > > These 2 DFSClient methods should use default directory permission to create a > directory. > {code:java} > public boolean mkdirs(String src, FsPermission permission, > boolean createParent) throws IOException { > if (permission == null) { > permission = FsPermission.getDefault(); > } > {code} > {code:java} > public boolean primitiveMkdir(String src, FsPermission absPermission, > boolean createParent) > throws IOException { > checkOpen(); > if (absPermission == null) { > absPermission = > FsPermission.getDefault().applyUMask(dfsClientConf.uMask); > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org