[ 
https://issues.apache.org/jira/browse/HDFS-10681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Manoj Govindassamy updated HDFS-10681:
--------------------------------------
    Attachment: HDFS-10681.001.patch

Thanks a lot Andrew. Uploading the new patch in the suggested format and based 
on latest trunk.

Before Fix:
{noformat}
CLI:
16/06/20 15:42:16 INFO command.Command: Executing "query plan" command.
Plan ID: 
04f41e2e1fa2d63558284be85155ea68154fb6ab435f1078c642d605d06626f176da16b321b35c99f1f6cd0cd77090c8743bb9a19190c4a01b5f8c51a515e240
 Result: PLAN_UNDER_PROGRESS
{noformat}


After Fix:
{noformat}
CLI:
3128 2016-07-27 09:18:24,219 [main] INFO  command.Command 
(QueryCommand.java:execute(57)) - Executing "query plan" command.
3129 Plan File: <plan file full path>
3130 Plan ID: <sha 512>
3131 Result: <plan state>

Logs:
2016-07-27 09:08:52,882 [DiskBalancerThread] INFO  datanode.DiskBalancer 
(DiskBalancer.java:run(491)) - Executing Disk balancer plan. Plan File: 
/system/current.plan.json, Plan ID: 
43fd5d34d0d6cd2e2c835bd0d4ace0ddce83bb3ff4721f8811289110e50929b80d63a43a511255f728498dece66569aad43c9ae15b76d9305cda539410363e66
2016-07-27 09:08:52,902 [DiskBalancerThread] INFO  datanode.DiskBalancer 
(DiskBalancer.java:run(491)) - Executing Disk balancer plan. Plan File: 
/system/current.plan.json, Plan ID: 
43fd5d34d0d6cd2e2c835bd0d4ace0ddce83bb3ff4721f8811289110e50929b80d63a43a511255f728498dece66569aad43c9ae15b76d9305cda539410363e66
2016-07-27 09:08:56,005 [DiskBalancerThread] INFO  datanode.DiskBalancer 
(DiskBalancer.java:run(491)) - Executing Disk balancer plan. Plan File: 
/system/current.plan.json, Plan ID: 
e391a843c641af67e61dfdc3dfbc0efecd9609f914251cc9e4b037e33e50ca8f6b1d6ea12ab917f06dd1d8f3e358d15c01ccf1cda0c9ede5dceb136ac841dd27
2016-07-27 09:08:57,035 [DiskBalancerThread] INFO  datanode.DiskBalancer 
(DiskBalancer.java:run(491)) - Executing Disk balancer plan. Plan File: 
/system/current.plan.json, Plan ID: 
5061437860f352866444231f5526611ce26911918ccb2a075e181af404f912ff604dd6c919107f8bc8b0535d1addb28a30f28a760457102d9d5bbd42833291d3
2016-07-27 09:09:00,065 [DiskBalancerThread] INFO  datanode.DiskBalancer 
(DiskBalancer.java:run(491)) - Executing Disk balancer plan. Plan File: 
/system/current.plan.json, Plan ID: 
2d8a29dceb21bf489e9bcc494fa606dc533a3e2577daccc705732400ee3b38675e8259d9950e005ba33b83550184620aaf39742787c0fe3496ed1f4f99ec24b6
{noformat}




> DiskBalancer: query command should report Plan file path apart from PlanID
> --------------------------------------------------------------------------
>
>                 Key: HDFS-10681
>                 URL: https://issues.apache.org/jira/browse/HDFS-10681
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: diskbalancer
>    Affects Versions: 3.0.0-alpha1
>            Reporter: Manoj Govindassamy
>            Assignee: Manoj Govindassamy
>            Priority: Minor
>         Attachments: HDFS-10681-HDFS-1312.001.patch, 
> HDFS-10681-HDFS-1312.002.patch, HDFS-10681.001.patch
>
>
> DiskBalancer query command currently reports planID (SHA512 hex) only. 
> Currently ongoing disk balancing activity in a datanode can be cancelled 
> wither by planID + datanode_address or just by pointing to the right plan 
> file. Since there could be many plan files, to avoid ambiguity its better if 
> query command can report the plan file path also.
> {noformat}
> $ hdfs diskbalancer --help query 
> usage: hdfs diskbalancer -query <hostname>  [options]
> Query Plan queries a given data node about the current state of disk
> balancer execution.
>     --query <arg>   Queries the disk balancer status of a given datanode.
> Query command retrievs *the plan ID* and the current running state.
> {noformat}
> Sample query command output:
> {noformat}
> 16/06/20 15:42:16 INFO command.Command: Executing "query plan" command.
> Plan ID: 
> 04f41e2e1fa2d63558284be85155ea68154fb6ab435f1078c642d605d06626f176da16b321b35c99f1f6cd0cd77090c8743bb9a19190c4a01b5f8c51a515e240
>  Result: PLAN_UNDER_PROGRESS
> or
> 16/06/20 15:46:09 INFO command.Command: Executing "query plan" command.
> Plan ID: 
> 04f41e2e1fa2d63558284be85155ea68154fb6ab435f1078c642d605d06626f176da16b321b35c99f1f6cd0cd77090c8743bb9a19190c4a01b5f8c51a515e240
>  Result: PLAN_DONE
> {noformat}
> Cancel command syntax:
> {noformat}
> $ hdfs diskbalancer --help cancel
> *usage: hdfs diskbalancer -cancel <planFile> | -cancel <planID> -node
>             <hostname>*
> Cancel command cancels a running disk balancer operation.
>     --cancel <arg>   Cancels a running plan using a plan file.
>     --node <arg>     Cancels a running plan using a plan ID and hostName
> Cancel command can be run via pointing to a plan file, or by reading the
> plan ID using the query command and then using planID and hostname.
> Examples of how to run this command are
> hdfs diskbalancer -cancel <planfile>
> hdfs diskbalancer -cancel <planID> -node <hostname>
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to