[ 
https://issues.apache.org/jira/browse/HDFS-10707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15405167#comment-15405167
 ] 

Akira Ajisaka commented on HDFS-10707:
--------------------------------------

Thanks [~vincentpoon] for rebasing the patch! Minor nit:
{code:title=FSDirStatAndListingOp.java}
-    final String startAfterString = new String(startAfter, Charsets.UTF_8);
+    final String startAfterString = new String(startAfter, 
StandardCharsets.UTF_8);
{code}
Would you render the line within 80 chars to fix the checkstyle warning? I'm +1 
if that is addressed.

> Replace org.apache.commons.io.Charsets with java.nio.charset.StandardCharsets
> -----------------------------------------------------------------------------
>
>                 Key: HDFS-10707
>                 URL: https://issues.apache.org/jira/browse/HDFS-10707
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 2.7.2
>            Reporter: Vincent Poon
>            Assignee: Vincent Poon
>            Priority: Minor
>             Fix For: 3.0.0-alpha2
>
>         Attachments: HDFS-10707.2.patch, HDFS-10707.3.patch, 
> HDFS-10707.branch-2.patch, HDFS-10707.patch
>
>
> org.apache.commons.io.Charsets is deprecated in favor of 
> java.nio.charset.StandardCharsets



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to