[ https://issues.apache.org/jira/browse/HDFS-4176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15405585#comment-15405585 ]
Surendra Singh Lilhore commented on HDFS-4176: ---------------------------------------------- Hi [~eddyxu] One minor comments. {code} + public static final String DFS_HA_TAILEDITS_ROLLEDITS_TIMEOUT_KEY = + "dfs.ha.tail-edits.rolledits.timeout"; {code} Can we rename this property to {{dfs.ha.log-roll.execution.timeout}} ?. It will be in sync with {{dfs.ha.log-roll.rpc.timeout}} > EditLogTailer should call rollEdits with a timeout > -------------------------------------------------- > > Key: HDFS-4176 > URL: https://issues.apache.org/jira/browse/HDFS-4176 > Project: Hadoop HDFS > Issue Type: Bug > Components: ha, namenode > Affects Versions: 2.0.2-alpha, 3.0.0-alpha1 > Reporter: Todd Lipcon > Assignee: Lei (Eddy) Xu > Attachments: HDFS-4176-branch-2.0.patch, > HDFS-4176-branch-2.003.patch, HDFS-4176-branch-2.1.patch, > HDFS-4176-branch-2.2.patch, HDFS-4176.00.patch, HDFS-4176.01.patch, > HDFS-4176.02.patch, HDFS-4176.03.patch, HDFS-4176.04.patch, namenode.jstack4 > > > When the EditLogTailer thread calls rollEdits() on the active NN via RPC, it > currently does so without a timeout. So, if the active NN has frozen (but not > actually crashed), this call can hang forever. This can then potentially > prevent the standby from becoming active. > This may actually considered a side effect of HADOOP-6762 -- if the RPC were > interruptible, that would also fix the issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org