[ 
https://issues.apache.org/jira/browse/HDFS-10342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15412417#comment-15412417
 ] 

Kuhu Shukla commented on HDFS-10342:
------------------------------------

TestTracing, TestRefreshUserMappings fail with or without the patch. 
TestDataNodeLifeline, TestReplicationPolicy, TestLazyPersistReplicaRecovery 
pass locally.  Requesting [~kihwal] for review/comments. Thanks a lot.

> BlockManager#createLocatedBlocks should not check corrupt replicas if none 
> are corrupt
> --------------------------------------------------------------------------------------
>
>                 Key: HDFS-10342
>                 URL: https://issues.apache.org/jira/browse/HDFS-10342
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs
>    Affects Versions: 2.7.0
>            Reporter: Daryn Sharp
>            Assignee: Kuhu Shukla
>         Attachments: HDFS-10342.001.patch, HDFS-10342.002.patch, 
> HDFS-10342.003.patch
>
>
> {{corruptReplicas#isReplicaCorrupt(block, node)}} is called for every node 
> while populating the machines array.  There's no need to invoke the method if 
> {{corruptReplicas#numCorruptReplicas(block)}} returned 0.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to