[ https://issues.apache.org/jira/browse/HDFS-10723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15412821#comment-15412821 ]
Yiqun Lin commented on HDFS-10723: ---------------------------------- Hi, [~vrushalic], some comments from me: 1.We can just removed the method {{nameNodePort(nnport)}} for here as @kihwal Lee said if the test is not trying to use the same port. But in this test, I am not so sure for that, because it show this: {code} // restart cluster with the same namenode port as before. // This ensures that leases are persisted in fsimage. {code} So we may be to confirm for this. 2.I see there were some similar failed test in {{TestFileCreationDelete}}(https://builds.apache.org/job/PreCommit-HDFS-Build/16290/testReport/). If we can also fix in this jira, it will be better. These two tests seems very similar. 3.Just attach your patch and trigger the button {{submit patch}}. If your patch was accepted by the commiters, they will assign this lira to you. Thanks. > TestRenameWhileOpen tries to restart NN with the same rpc port > -------------------------------------------------------------- > > Key: HDFS-10723 > URL: https://issues.apache.org/jira/browse/HDFS-10723 > Project: Hadoop HDFS > Issue Type: Bug > Components: test > Reporter: Kihwal Lee > Attachments: testWhileOpenRenameParentToNonexistentDir.txt > > > In {{testWhileOpenRenameParentToNonexistentDir}}, > {code} > // restart cluster with the same namenode port as before. > // This ensures that leases are persisted in fsimage. > cluster.shutdown(); > {code} > And we are getting test failures in precommit builds. > {noformat} > java.net.BindException: Problem binding to [localhost:47395] > java.net.BindException: Address already in use; > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org