[
https://issues.apache.org/jira/browse/HDFS-10608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15414010#comment-15414010
]
Surendra Singh Lilhore commented on HDFS-10608:
-----------------------------------------------
Thanks [~churromorales] for the patch..
Some review comment from my side..
1. I feel event should give only info of newly added block name (blk_xxxxxxxx),
generationStamp, file path, blockPoolId. No need of giving {{penultimateBlock}}
info.
2. Remove unused import from {{InotifyFSEditLogOpTranslator.java}}
{code}
+import org.apache.hadoop.hdfs.protocol.ClientProtocol;
+import org.apache.hadoop.hdfs.protocol.ExtendedBlock;
+import org.apache.hadoop.hdfs.server.blockmanagement.BlockInfo;
{code}
3. In test class don't change the assertion which is not related to this patch.
4. Please fix the check style issue..
> Include event for AddBlock in Inotify Event Stream
> --------------------------------------------------
>
> Key: HDFS-10608
> URL: https://issues.apache.org/jira/browse/HDFS-10608
> Project: Hadoop HDFS
> Issue Type: Task
> Reporter: churro morales
> Priority: Minor
> Attachments: HDFS-10608.patch, HDFS-10608.v1.patch
>
>
> It would be nice to have an AddBlockEvent in the INotify pipeline. Based on
> discussions from mailing list:
> http://mail-archives.apache.org/mod_mbox/hadoop-hdfs-dev/201607.mbox/%3C1467743792.4040080.657624289.7BE240AD%40webmail.messagingengine.com%3E
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
