[ https://issues.apache.org/jira/browse/HDFS-8905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15430113#comment-15430113 ]
Kai Zheng commented on HDFS-8905: --------------------------------- Hi Sammi, The latest change looks good. One comment for the {{readFromBuffer}} call, would you help check if we need to forward the position of the {{src}} buffer? Can we add some comment about this to note the position of the src buffer is changed or not after the call? Thanks. > Refactor DFSInputStream#ReaderStrategy > -------------------------------------- > > Key: HDFS-8905 > URL: https://issues.apache.org/jira/browse/HDFS-8905 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: erasure-coding > Reporter: Kai Zheng > Assignee: SammiChen > Attachments: HDFS-8905-HDFS-7285-v1.patch, HDFS-8905-v10.patch, > HDFS-8905-v11.patch, HDFS-8905-v12.patch, HDFS-8905-v13.patch, > HDFS-8905-v2.patch, HDFS-8905-v3.patch, HDFS-8905-v4.patch, > HDFS-8905-v5.patch, HDFS-8905-v6.patch, HDFS-8905-v7.patch, > HDFS-8905-v8.patch, HDFS-8905-v9.patch > > > DFSInputStream#ReaderStrategy family don't look very good. This refactors a > little bit to make them make more sense. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org