[ https://issues.apache.org/jira/browse/HDFS-10713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15449776#comment-15449776 ]
Arpit Agarwal commented on HDFS-10713: -------------------------------------- Thanks for the patch [~hanishakoneru]. # We can do the timestamp checks just before the {{this.fsLock.writeLock().unlock()}} call, so the new state is protected by the write lock. The actual logging can be done outside the write lock though. Then you don't need to make the members volatile anymore. # We can cache the value returned by {{monotonicNow()}} instead of calling it twice. > Throttle FsNameSystem lock warnings > ----------------------------------- > > Key: HDFS-10713 > URL: https://issues.apache.org/jira/browse/HDFS-10713 > Project: Hadoop HDFS > Issue Type: Bug > Components: logging, namenode > Reporter: Arpit Agarwal > Assignee: Hanisha Koneru > Attachments: HDFS-10713.000.patch > > > The NameNode logs a message if the FSNamesystem write lock is held by a > thread for over 1 second. These messages can be throttled to at one most one > per x minutes to avoid potentially filling up NN logs. We can also log the > number of suppressed notices since the last log message. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org