[ https://issues.apache.org/jira/browse/HDFS-10745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15460300#comment-15460300 ]
Xiao Chen commented on HDFS-10745: ---------------------------------- Thanks for working on this, Daryn and Kihwal. It seems this change introduced a findbugs warning in branch-2. {noformat} Code Warning DLS Dead store to src in org.apache.hadoop.hdfs.server.namenode.FSDirAppendOp.appendFile(FSNamesystem, String, FSPermissionChecker, String, String, boolean, boolean) Bug type DLS_DEAD_LOCAL_STORE (click for details) In class org.apache.hadoop.hdfs.server.namenode.FSDirAppendOp In method org.apache.hadoop.hdfs.server.namenode.FSDirAppendOp.appendFile(FSNamesystem, String, FSPermissionChecker, String, String, boolean, boolean) Local variable named src At FSDirAppendOp.java:[line 92] {noformat} > Directly resolve paths into INodesInPath > ---------------------------------------- > > Key: HDFS-10745 > URL: https://issues.apache.org/jira/browse/HDFS-10745 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs > Reporter: Daryn Sharp > Assignee: Daryn Sharp > Fix For: 2.8.0, 3.0.0-alpha1 > > Attachments: HDFS-10745.2.patch, HDFS-10745.branch-2.patch, > HDFS-10745.patch > > > The intermediate resolution to a string, only to be decomposed by > {{INodesInPath}} back into a byte[][] can be eliminated by resolving directly > to an IIP. The IIP will contain the resolved path if required. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org