[
https://issues.apache.org/jira/browse/HDFS-10835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15463562#comment-15463562
]
Allen Wittenauer commented on HDFS-10835:
-----------------------------------------
bq. you probably already know this: kms.sh is pretty much the same. Have we
considered abstract the helper function somehow?
It's almost all boiler plate now. Plus every three months someone says "we are
using an old version of tomcat" followed by a "we shouldn't really be using
tomcat" and then nothing happens. As soon as someone actually does the work to
get us off of tomcat, this code should hopefully re-arrange into something else
that looks more like the rest of Hadoop rather than clearly written as a
one-off.
As to the code, I don't really understand why the name var exists, but whatever.
> Typo in httpfs.sh hadoop_usage
> ------------------------------
>
> Key: HDFS-10835
> URL: https://issues.apache.org/jira/browse/HDFS-10835
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: httpfs
> Affects Versions: 3.0.0-alpha1
> Reporter: John Zhuge
> Assignee: John Zhuge
> Priority: Trivial
> Attachments: HDFS-10835.001.patch, HDFS-10835.002.patch,
> HDFS-10835.003.patch, HDFS-10835.004.patch
>
>
> Typo in method {{hadoop_usage}} of {{httpfs.sh}}. The {{kms}} words should be
> replaced with {{httpfs}}:
> {noformat}
> function hadoop_usage
> {
> hadoop_add_subcommand "run" "Start kms in the current window"
> hadoop_add_subcommand "run -security" "Start in the current window with
> security manager"
> hadoop_add_subcommand "start" "Start kms in a separate window"
> hadoop_add_subcommand "start -security" "Start in a separate window with
> security manager"
> hadoop_add_subcommand "status" "Return the LSB compliant status"
> hadoop_add_subcommand "stop" "Stop kms, waiting up to 5 seconds for the
> process to end"
> hadoop_add_subcommand "top n" "Stop kms, waiting up to n seconds for the
> process to end"
> hadoop_add_subcommand "stop -force" "Stop kms, wait up to 5 seconds and
> then use kill -KILL if still running"
> hadoop_add_subcommand "stop n -force" "Stop kms, wait up to n seconds and
> then use kill -KILL if still running"
> hadoop_generate_usage "${MYNAME}" false
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
