[
https://issues.apache.org/jira/browse/HDFS-10742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Douglas updated HDFS-10742:
---------------------------------
Attachment: HDFS-10742.015.patch
Modified v014 of the patch to show the alternative, since I could not convey
the design in prose:
* Changed {{AutoClosableLock}} and {{InstrumentedLock}} to wrap a {{Lock}}
instance, rather than hard-coding {{ReentrantLock}}
* Changed visibility of {{AutoCloseableLock#isLocked}} to package-private for
unit tests, and annotated same
* Changed time arithmetic to match
[guidance|https://docs.oracle.com/javase/8/docs/api/java/lang/System.html#nanoTime--]
for {{System#nanotime}}
* Changed init to not suppress the first lock warning if the first acquisition
is within the log delay period
* Changed logging check to avoid synchronizing on the instance
* Changed the unit test to use {{Timer}} instead of {{Thread#sleep}}
This retains most of the pattern as
[requested|https://issues.apache.org/jira/browse/HDFS-10742?focusedCommentId=15447205&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15447205].
> Measurement of lock held time in FsDatasetImpl
> ----------------------------------------------
>
> Key: HDFS-10742
> URL: https://issues.apache.org/jira/browse/HDFS-10742
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode
> Affects Versions: 3.0.0-alpha2
> Reporter: Chen Liang
> Assignee: Chen Liang
> Attachments: HDFS-10742.001.patch, HDFS-10742.002.patch,
> HDFS-10742.003.patch, HDFS-10742.004.patch, HDFS-10742.005.patch,
> HDFS-10742.006.patch, HDFS-10742.007.patch, HDFS-10742.008.patch,
> HDFS-10742.009.patch, HDFS-10742.010.patch, HDFS-10742.011.patch,
> HDFS-10742.012.patch, HDFS-10742.013.patch, HDFS-10742.014.patch,
> HDFS-10742.015.patch
>
>
> This JIRA proposes to measure the time the of lock of {{FsDatasetImpl}} is
> held by a thread. Doing so will allow us to measure lock statistics.
> This can be done by extending the {{AutoCloseableLock}} lock object in
> {{FsDatasetImpl}}. In the future we can also consider replacing the lock with
> a read-write lock.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
