[ https://issues.apache.org/jira/browse/HDFS-10821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yiqun Lin updated HDFS-10821: ----------------------------- Attachment: HDFS-10821.002.patch Thanks [~anu] for the review. {quote} so if you have an invalid node, along with valid nodes, I think we are going to ignore the invalid node silently. {quote} The method {{getNodes(nodeVal)}} will ignore the invalid node since the node is selected from the cluster rather than construct a new node. So if one node is a invalid node, the method {{DiskBalancerDataNode getNode(String nodeName)}} will return null and then it will be skipped. {quote} Could you please add a test case which passes an invalid node along with the valid set and make sure that report command detects the invalid node correctly. {quote} Done. Attach a new patch to address the comments, pending jenkins, > DiskBalancer: Report command support with multiple nodes > -------------------------------------------------------- > > Key: HDFS-10821 > URL: https://issues.apache.org/jira/browse/HDFS-10821 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: balancer & mover > Reporter: Yiqun Lin > Assignee: Yiqun Lin > Fix For: 2.9.0 > > Attachments: HDFS-10821.001.patch, HDFS-10821.002.patch > > > Since HDFS-10813 has committed to the trunk, then we can use {{getNodes}} > method to parse the nodes string and support multiple nodes with {{hdfs > diskbalancer}} subcommands(ex -report, -query). In this JIRA, we are focusing > on the subcommand {{-report}}. > That means we can use command {{hdfs diskbalancer -report -node}} to print > one or one more datanodes report info. A test input command(here I use UUID > to specify one datanode): > {code} > hdfs diskbalancer -report -node > e05ade8e-fb28-42cf-9aa9-43e564c0ec99,38714337-84fb-4e35-9ea3-0bb47d6da700 > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org