[ https://issues.apache.org/jira/browse/HDFS-10838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15478006#comment-15478006 ]
Arpit Agarwal commented on HDFS-10838: -------------------------------------- Thank you for the updated patch [~surendrasingh]. Looks good, two more comments. # Sorry for not catching this earlier - we should call {{node.setLastBlockReportTime(now());}} only if {{lastStorageInRpc}} is true i.e. when all storages have been processed. # Do you know what {{helper_relative_time_now}} will print if the value is zero? The current "a few seconds ago" looks great actually but I think we can print in the same format as heartbeat time so it remains numerically sortable. > Last full block report received time for each DN should be easily discoverable > ------------------------------------------------------------------------------ > > Key: HDFS-10838 > URL: https://issues.apache.org/jira/browse/HDFS-10838 > Project: Hadoop HDFS > Issue Type: Improvement > Components: ui > Reporter: Arpit Agarwal > Assignee: Surendra Singh Lilhore > Attachments: DFSAdmin-Report.png, HDFS-10838-001.patch, > HDFS-10838.002.patch, HDFS-10838.003.patch, NN_UI.png, NN_UI_relative_time.png > > > It should be easy for administrators to discover the time of last full block > report from each DataNode. > We can show it in the NameNode web UI or in the output of {{hdfs dfsadmin > -report}}, or both. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org