[
https://issues.apache.org/jira/browse/HDFS-10823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Wang updated HDFS-10823:
-------------------------------
Attachment: HDFS-10823.004.patch
Thanks for reviewing Xiao, new rev attached. Addressed except as per below:
bq. -- The new {{listStatus}} should {{return new DirectoryEntries(listing,
token, false);}}
I think it's correct as is. This default implementation lists the entire
directory as a single batch, so there is no next batch.
We could do some more work to truncate the listing to start at the passed token
and set the returned token to the last element, but I think this falls outside
of the spec since {{hasMore}} is always false and the token is supposed to come
from a previous call and be opaque.
bq. Maybe the helper methods can go to {{HttpFSUtils}}?
I think you're talking about {{toFileStatus}} here? That method is
unfortunately not static since {{makeQualified}} is not static, so we can't
move it.
bq. Maybe we could reorganize the code in {{listStatus}} to parse
{{remainingEntries}} first, then {{newToken}}, so that we don't need 2
duplicate comments.
I just deleted the dup comment. I like ordering the parsing in the order of the
arguments to DirectoryEntries.
bq. We'll need (a bunch of) documentation.
Any recommendations on additional docs? The batched listing API is already
covered in WebHDFS.md, and I think the javadoc coverage is pretty good.
> Implement HttpFSFileSystem#listStatusIterator
> ---------------------------------------------
>
> Key: HDFS-10823
> URL: https://issues.apache.org/jira/browse/HDFS-10823
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: httpfs
> Affects Versions: 2.6.4
> Reporter: Andrew Wang
> Assignee: Andrew Wang
> Attachments: HDFS-10823.001.patch, HDFS-10823.002.patch,
> HDFS-10823.003.patch, HDFS-10823.004.patch
>
>
> Let's expose the same functionality added in HDFS-10784 for WebHDFS in HttpFS
> too.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
