[
https://issues.apache.org/jira/browse/HDFS-10823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15494728#comment-15494728
]
Xiao Chen commented on HDFS-10823:
----------------------------------
Thanks for explaining, Andrew. Yeah what you said makes sense, and yep, javadoc
coverage is great. :)
Some more comments:
bq. This default implementation lists the entire directory as a single batch,
so there is no next batch.
Thanks for explaining, sgtm. Is it possible to clarify this for the default
implementation from javadoc or log?
bq. Any recommendations on additional docs
Sorry I forgot HttpFs didn't have it's own doc.... And the new changes to FS
aren't supposed to be used by user, so we're good here. :)
Somre more cosmetic things:
- FSOperations
-- {{FSListStatusBatch}}'s member vars could be final
- HttpFSFileSystem
-- I see we check null on {{remainingEntries}} but not on {{DirectoryListing}}
or {{partialListing}}, is this intentional?
-- Suggest to add {{DirectoryListing}} as a predefined constant too, and use
the constants.
Test failure seems related, but generally looks pretty good to me.
> Implement HttpFSFileSystem#listStatusIterator
> ---------------------------------------------
>
> Key: HDFS-10823
> URL: https://issues.apache.org/jira/browse/HDFS-10823
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: httpfs
> Affects Versions: 2.6.4
> Reporter: Andrew Wang
> Assignee: Andrew Wang
> Attachments: HDFS-10823.001.patch, HDFS-10823.002.patch,
> HDFS-10823.003.patch, HDFS-10823.004.patch
>
>
> Let's expose the same functionality added in HDFS-10784 for WebHDFS in HttpFS
> too.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
