[ https://issues.apache.org/jira/browse/HDFS-10862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mehran Hassani updated HDFS-10862: ---------------------------------- Description: I am conducting research on log related bugs. I tried to make a tool to fix repetitive yet simple patterns of bugs that are related to logs. Typos in log messages are one of the reoccurring bugs. Therefore, I made a tool find typos in log statements. During my experiments, I managed to find the following typos in Hadoop HDFS: In file /hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeList.java, FsDatasetImpl.LOG.info("The volume " + v + " is closed while " +"addng replicas ignored."), addng should be adding In file /hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java, NameNode.LOG.info("Caching file names occuring more than " + threshold+ " times"), occuring should be occurring In file /hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NNStorage.java, LOG.info("NNStorage.attemptRestoreRemovedStorage: check removed(failed) "+"storarge. removedStorages size = " + removedStorageDirs.size()), storarge should be storage In file /hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/RpcProgramNfs3.java, LOG.info("Partical read. Asked offset: " + offset + " count: " + count+ " and read back: " + readCount + " file size: "+ attrs.getSize()), Partical should be Partial was: I am conducting research on log related bugs. I tried to make a tool to fix repetitive yet simple patterns of bugs that are related to logs. Typos in log messages are one of the reoccurring bugs. Therefore, I made a tool find typos in log statements. During my experiments, I managed to find the following typos in Hadoop HDFS: In file /hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPServiceActor.java, LOG.info((success ? "S" : "Uns") +"uccessfully sent block report 0x" +Long.toHexString(reportId) + " containing " + reports.length +" storage report(s) of which we sent " + numReportsSent + "." +" The reports had " + totalBlockCount +" total blocks and used " + numRPCs +" RPC(s). This took " + brCreateCost +" msec to generate and " + brSendCost +" msecs for RPC and NN processing." +" Got back " +((nCmds == 0) ? "no commands" : ((nCmds == 1) ? "one command: " + cmds.get(0) :(nCmds + " commands: " + Joiner.on("; ").join(cmds)))) +"."), uccessfully successfully In file /hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiverServer.java, LOG.info("Balancing bandwith is " + bandwidth + " bytes/s"), bandwith should be bandwidth In file /hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeList.java, FsDatasetImpl.LOG.info("The volume " + v + " is closed while " +"addng replicas ignored."), addng should be adding In file /hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/CancelDelegationTokenServlet.java, LOG.info("Exception while cancelling token. Re-throwing. " e), cancelling should be canceling In file /hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java, NameNode.LOG.info("Caching file names occuring more than " + threshold+ " times"), occuring should be occurring In file /hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NNStorage.java, LOG.info("NNStorage.attemptRestoreRemovedStorage: check removed(failed) "+"storarge. removedStorages size = " + removedStorageDirs.size()), storarge should be storage In file /hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/RpcProgramNfs3.java, LOG.info("Partical read. Asked offset: " + offset + " count: " + count+ " and read back: " + readCount + " file size: "+ attrs.getSize()), Partical should be Partial > Typos in 7 log messages > ----------------------- > > Key: HDFS-10862 > URL: https://issues.apache.org/jira/browse/HDFS-10862 > Project: Hadoop HDFS > Issue Type: Bug > Reporter: Mehran Hassani > Priority: Trivial > Labels: newbie > > I am conducting research on log related bugs. I tried to make a tool to fix > repetitive yet simple patterns of bugs that are related to logs. Typos in log > messages are one of the reoccurring bugs. Therefore, I made a tool find typos > in log statements. During my experiments, I managed to find the following > typos in Hadoop HDFS: > In file > /hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeList.java, > FsDatasetImpl.LOG.info("The volume " + v + " is closed while " +"addng > replicas ignored."), > addng should be adding > In file > /hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java, > NameNode.LOG.info("Caching file names occuring more than " + threshold+ " > times"), > occuring should be occurring > In file > /hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NNStorage.java, > LOG.info("NNStorage.attemptRestoreRemovedStorage: check removed(failed) > "+"storarge. removedStorages size = " + removedStorageDirs.size()), > storarge should be storage > In file > /hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/RpcProgramNfs3.java, > LOG.info("Partical read. Asked offset: " + offset + " count: " + count+ " > and read back: " + readCount + " file size: "+ attrs.getSize()), > Partical should be Partial -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org