[jira] [Commented] (HDFS-10865) Datanodemanager adds nodes twice to NetworkTopology

[Inigo Goiri (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HDFS-10865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15494894#comment-15494894
 ] 

Inigo Goiri commented on HDFS-10865:
------------------------------------

Currently, {{DatanodeManager}} in {{registerDatanode(...)}}, it does the 
following:
{code}
  public void registerDatanode(DatanodeRegistration nodeReg)
      throws DisallowedDatanodeException, UnresolvedTopologyException {
        ...
        networktopology.add(nodeDescr);
        nodeDescr.setSoftwareVersion(nodeReg.getSoftwareVersion());
        resolveUpgradeDomain(nodeDescr);

        // register new datanode
        addDatanode(nodeDescr);
        ...
  }
{code}

Then, {{addDatanode()}} does it again:
{code}
  void addDatanode(final DatanodeDescriptor node) {
    ....
    networktopology.add(node); // may throw InvalidTopologyException
    ...
  }
{code}

This was introduced in HDFS-4521. My proposal is to remove it from 
{{registerDatanode()}} and rely solely in {{addDatanode()}}.

> Datanodemanager adds nodes twice to NetworkTopology
> ---------------------------------------------------
>
>                 Key: HDFS-10865
>                 URL: https://issues.apache.org/jira/browse/HDFS-10865
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: datanode
>    Affects Versions: 2.7.3
>            Reporter: Inigo Goiri
>            Assignee: Inigo Goiri
>
> {{DatanodeManager}} tries to add datanodes to the {{NetworkTopology}} twice 
> in {{registerDatanode()}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org