[
https://issues.apache.org/jira/browse/HDFS-10713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15498130#comment-15498130
]
Arpit Agarwal commented on HDFS-10713:
--------------------------------------
v10 patch lgtm. I think this block was left in by mistake in the second
do-while loop in readUnlock, it can be removed.
{code}
localLongestReadLock = longestReadLockHeldInterval.get();
if (readLockInterval > localLongestReadLock) {
longestReadLockHeldInterval.compareAndSet(
localLongestReadLock, readLockInterval);
}
{code}
Will hold off committing until next week in case Chris, Erik or others have
additional comments.
> Throttle FsNameSystem lock warnings
> -----------------------------------
>
> Key: HDFS-10713
> URL: https://issues.apache.org/jira/browse/HDFS-10713
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: logging, namenode
> Reporter: Arpit Agarwal
> Assignee: Hanisha Koneru
> Attachments: HDFS-10713.000.patch, HDFS-10713.001.patch,
> HDFS-10713.002.patch, HDFS-10713.003.patch, HDFS-10713.004.patch,
> HDFS-10713.005.patch, HDFS-10713.006.patch, HDFS-10713.007.patch,
> HDFS-10713.008.patch, HDFS-10713.009.patch, HDFS-10713.010.patch
>
>
> The NameNode logs a message if the FSNamesystem write lock is held by a
> thread for over 1 second. These messages can be throttled to at one most one
> per x minutes to avoid potentially filling up NN logs. We can also log the
> number of suppressed notices since the last log message.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
