[ https://issues.apache.org/jira/browse/HDFS-10896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15530725#comment-15530725 ]
Hanisha Koneru commented on HDFS-10896: --------------------------------------- +1 for v3 patch. Thanks [~xkrogen] for including changes from HDFS-10713. > Move lock logging logic from FSNamesystem into FSNamesystemLock > --------------------------------------------------------------- > > Key: HDFS-10896 > URL: https://issues.apache.org/jira/browse/HDFS-10896 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: namenode > Reporter: Erik Krogen > Assignee: Erik Krogen > Labels: logging, namenode > Attachments: HDFS-10896.000.patch, HDFS-10896.001.patch, > HDFS-10896.002.patch, HDFS-10896.003.patch > > > There are a number of tickets (HDFS-10742, HDFS-10817, HDFS-10713, this > subtask's story HDFS-10475) which are adding/improving logging/metrics around > the {{FSNamesystemLock}}. All of this is done in {{FSNamesystem}} right now, > which is polluting the namesystem with ThreadLocal variables, timing > counters, etc. which are only relevant to the lock itself and the number of > these increases as the logging/metrics become more sophisticated. It would be > best to move these all into FSNamesystemLock to keep the metrics/logging tied > directly to the item of interest. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org