[ 
https://issues.apache.org/jira/browse/HDFS-10921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15533396#comment-15533396
 ] 

Erik Krogen commented on HDFS-10921:
------------------------------------

[~shahrs87], the concern about namespace pollution is valid, but this is why 
the first line of each of the tests is to create a Path that is unique to the 
given test case and all subsequent operations occur under that Path.  
Especially given the error that Eric has posted, I don't think that is the 
issue. 

The reason that {{cluster.restartNameNodes()}} is called, IIUC, is to initiate 
a check of the edit log to ensure that edits aren't corrupted as per the 
comment right above the call - previously the cluster was completely recreated 
after each test case so there would be no reason (in terms of cleaning) to 
restart the namenode at the end of the test. Pinging [~jingzhao] to confirm.

[~ebadger], first off, good catch. Apologies for introducing this bug. Can we 
just change the calls to {{cluster.restartNameNodes()}} to 
{{cluster.restartNameNode(true)}}? There is only one NN in this test so we can 
just use the already-available method on {{MiniDFSCluster}} and keep the change 
local to the test itself. 

> TestDiskspaceQuotaUpdate doesn't wait for NN to get out of safe mode
> --------------------------------------------------------------------
>
>                 Key: HDFS-10921
>                 URL: https://issues.apache.org/jira/browse/HDFS-10921
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Eric Badger
>            Assignee: Eric Badger
>         Attachments: HDFS-10921.001.patch, HDFS-10921.002.patch
>
>
> Test fails intermittently because the NN is still in safe mode. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to