[ 
https://issues.apache.org/jira/browse/HDFS-10950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15543723#comment-15543723
 ] 

Chris Nauroth commented on HDFS-10950:
--------------------------------------

Hello [~xiaobingo].  Do you think this is already covered sufficiently in 
{{TestSafeMode#testOperationsWhileInSafeMode}}?

{code}
    runFsFun("modifyAclEntries while in SM", new FSRun() {
      @Override
      public void run(FileSystem fs) throws IOException {
        fs.modifyAclEntries(file1, Lists.<AclEntry>newArrayList());
      }});

    runFsFun("removeAclEntries while in SM", new FSRun() {
      @Override
      public void run(FileSystem fs) throws IOException {
        fs.removeAclEntries(file1, Lists.<AclEntry>newArrayList());
      }});

    runFsFun("removeDefaultAcl while in SM", new FSRun() {
      @Override
      public void run(FileSystem fs) throws IOException {
        fs.removeDefaultAcl(file1);
      }});

    runFsFun("removeAcl while in SM", new FSRun() {
      @Override
      public void run(FileSystem fs) throws IOException {
        fs.removeAcl(file1);
      }});

    runFsFun("setAcl while in SM", new FSRun() {
      @Override
      public void run(FileSystem fs) throws IOException {
        fs.setAcl(file1, Lists.<AclEntry>newArrayList());
      }});

...

    try {
      fs.getAclStatus(file1);
    } catch (IOException ioe) {
      fail("getAclStatus failed while in SM");
    }
{code}


> Add unit tests to verify ACLs in safemode
> -----------------------------------------
>
>                 Key: HDFS-10950
>                 URL: https://issues.apache.org/jira/browse/HDFS-10950
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: fs, test
>            Reporter: Xiaobing Zhou
>            Assignee: Xiaobing Zhou
>
> This proposes adding unit tests to validate that getting Acls works when 
> namende is in safemode, while setting Acls fails.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to