[ https://issues.apache.org/jira/browse/HDFS-10965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15553400#comment-15553400 ]
Mingliang Liu commented on HDFS-10965: -------------------------------------- Thanks for the patch, [~xiaobingo]. Can you update the patch to address/consider the common comments I made in [HDFS-10972]? Thanks. > Add unit test for HDFS command 'dfsadmin -printTopology' > -------------------------------------------------------- > > Key: HDFS-10965 > URL: https://issues.apache.org/jira/browse/HDFS-10965 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: fs, shell, test > Reporter: Xiaobing Zhou > Assignee: Xiaobing Zhou > Attachments: HDFS-10965.000.patch, HDFS-10965.001.patch, > HDFS-10965.002.patch, HDFS-10965.003.patch > > > DFSAdmin#printTopology should also be tested. This proposes adding it in > TestDFSAdmin. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org