[
https://issues.apache.org/jira/browse/HDFS-10938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15567313#comment-15567313
]
Xiaoyu Yao commented on HDFS-10938:
-----------------------------------
Thanks [~anu] for reporting the issue and posting the patch. The patch looks
good to me overall. Here are some comments:
1. The description below is not very clear to me. It looks like we are not
defining the RequestProto for
RegisteredCmdResponseProto/SCMHeartbeatResponseProto.
Can we add some comments that we are reusing the SCMHeartbeatRequestProto for
both register and heartbeat?
{code}
144 * If registration is need datanode moves into REGISTERING_NODE state.
It will
145 * send a register call with datanodeID data structure, but with
datanode UUID
146 * will be set to an empty string.
{code}
2. NIT: some extra space
{code}
rpc getVersion(SCMVersionRequestProto) returns (SCMVersionResponseProto);
{code}
> Ozone: SCM: Add datanode protocol
> ---------------------------------
>
> Key: HDFS-10938
> URL: https://issues.apache.org/jira/browse/HDFS-10938
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Affects Versions: HDFS-7240
> Reporter: Anu Engineer
> Assignee: Anu Engineer
> Fix For: HDFS-7240
>
> Attachments: HDFS-10938-HDFS-7240.001.patch
>
>
> Adds the datanode protoc file. This file is not used as of yet. Adding this
> as a separate file to make sure it is easy to code review and discuss the
> protocol in isolation. The protocol will be used in future patches.
> This file defines how a datanode communicates with SCM.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
