[ 
https://issues.apache.org/jira/browse/HDFS-10921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15572550#comment-15572550
 ] 

Erik Krogen edited comment on HDFS-10921 at 10/13/16 5:09 PM:
--------------------------------------------------------------

Should we still change {{restartNameNodes}} to {{restartNameNode(true)}}? 
Correctness shouldn't be impacted either way because of the {{@Before}} block 
but it may help to reduce the number of times that the {{@Before}} block's 
condition hit. I'm assuming that doing the extra call to {{waitClusterUp}} as a 
result (inside of {{restartNameNode}}) will be faster than starting an entirely 
new cluster. 
LGTM either way though, just a minor detail. 


was (Author: xkrogen):
Should we still change {{restartNameNodes}} to {{restartNameNode(true)}}? 
Correctness shouldn't be impacted either way because of the {{@Before}} block 
but it may help to reduce the number of times that the {{@Before}} block's 
condition hit. I'm assuming that doing the extra call to {{waitClusterUp}} as a 
result (inside of {{restartNameNode}}) will be faster than starting an entirely 
new cluster. 

> TestDiskspaceQuotaUpdate doesn't wait for NN to get out of safe mode
> --------------------------------------------------------------------
>
>                 Key: HDFS-10921
>                 URL: https://issues.apache.org/jira/browse/HDFS-10921
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Eric Badger
>            Assignee: Eric Badger
>         Attachments: HDFS-10921.001.patch, HDFS-10921.002.patch, 
> HDFS-10921.003.patch
>
>
> Test fails intermittently because the NN is still in safe mode. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to