[
https://issues.apache.org/jira/browse/HDFS-10872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15587033#comment-15587033
]
Zhe Zhang commented on HDFS-10872:
----------------------------------
Thanks Erik! The v3 patch LGTM. +1 pending fixing the long line checkstyle
issue.
{code}
* {@link
org.apache.hadoop.hdfs.DFSConfigKeys#DFS_NAMENODE_LOCK_METRIC_AGG_INTERVAL_MS_KEY}
{code}
I think we should leave the try-and-backoff as a potential optimization.
I will hold off committing the patch until EOD Thursday to collect more
feedbacks. [~kihwal] Do you think the patch addresses your [use cases |
https://issues.apache.org/jira/browse/HDFS-10475?focusedCommentId=15490522&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15490522]?
[~andrew.wang] Do you think the aggregation method addresses your concern on
performance (see benchmark above)? [~liuml07] Any comments on the form of
output?
> Add MutableRate metrics for FSNamesystemLock operations
> -------------------------------------------------------
>
> Key: HDFS-10872
> URL: https://issues.apache.org/jira/browse/HDFS-10872
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode
> Reporter: Erik Krogen
> Assignee: Erik Krogen
> Attachments: FSLockPerf.java, HDFS-10872.000.patch,
> HDFS-10872.001.patch, HDFS-10872.002.patch, HDFS-10872.003.patch
>
>
> Add metrics for FSNamesystemLock operations to see, overall, how long each
> operation is holding the lock for. Use MutableRate metrics for now.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
