[ https://issues.apache.org/jira/browse/HDFS-11018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15590359#comment-15590359 ]
Yiqun Lin commented on HDFS-11018: ---------------------------------- Thanks [~jojochuang] for the review. One point that I want to say, the test {{TestDiskspaceQuotaUpdate}} fails in this JIRA. I found the reason is that there is some bind exception. I have filed the JIRA HDFS-11025 to make a quick fix. We have reach an agreement that back up on different port across restarting datanode will not influce the current logic. So I have one proposal that you can also make a commit for that after you have looked into for that, :). Thanks. > Incorrect check and message in FsDatasetImpl#invalidate > ------------------------------------------------------- > > Key: HDFS-11018 > URL: https://issues.apache.org/jira/browse/HDFS-11018 > Project: Hadoop HDFS > Issue Type: Bug > Components: datanode > Reporter: Wei-Chiu Chuang > Assignee: Yiqun Lin > Attachments: HDFS-11018.001.patch, HDFS-11018.002.patch, > HDFS-11018.003.patch > > > The following error check and message is incorrect, because {{info}} is null > if (1) the block id does not exist in ReplicaMap or (2) the generation stamp > of block does not match the replica entry in ReplicaMap. > {code:title=FsDatasetImpl#invalidate} > final ReplicaInfo info = volumeMap.get(bpid, invalidBlks[i]); > if (info == null) { > // It is okay if the block is not found -- it may be deleted > earlier. > LOG.info("Failed to delete replica " + invalidBlks[i] > + ": ReplicaInfo not found."); > continue; > } > if (info.getGenerationStamp() != invalidBlks[i].getGenerationStamp()) > { > errors.add("Failed to delete replica " + invalidBlks[i] > + ": GenerationStamp not matched, info=" + info); > continue; > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org