[
https://issues.apache.org/jira/browse/HDFS-9482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15590872#comment-15590872
]
Arpit Agarwal commented on HDFS-9482:
-------------------------------------
Thank you for contributing this improvement [~brahmareddy]. A few comments:
# Fields {{from}} and {{nodeID}} in DatanodeInfoBuilder should be removed. They
seem to be unused.
# DataNodeInfo has a number of unused constructors now. We should probably
remove them.
# DatanodeInfoBuilder can be a static nested class of DatanodeInfo.
# Generally when we use a builder pattern, the constructor is made private to
enforce construction via the builder. Is it possible to do that here?
Looks good otherwise.
> Replace DatanodeInfo constructors with a builder pattern
> --------------------------------------------------------
>
> Key: HDFS-9482
> URL: https://issues.apache.org/jira/browse/HDFS-9482
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Brahma Reddy Battula
> Assignee: Brahma Reddy Battula
> Attachments: HDFS-9482-002.patch, HDFS-9482.patch
>
>
> As per [~arpitagarwal] comment
> [here|https://issues.apache.org/jira/browse/HDFS-9038?focusedCommentId=15018761&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15018761],Replace
> DatanodeInfo constructors with a builder pattern,
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
